This repository has been archived by the owner on May 24, 2024. It is now read-only.
Data grid add column actions #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data-grid-add-column-action
adoroshk
changed the title
… data-grid-add-column-action
… data-grid-add-column-action
sycombs
reviewed
Feb 26, 2024
| * Removed the default rowMinimumHeight from FlowsheetDataGrid so that the `terra-table` default value is used. | ||
|
|
||
| * Added | ||
| * Column actions support added. |
There was a problem hiding this comment.
nit (for consistency):
Suggested change
| * Column actions support added. | |
| * Added support for column actions. |
There was a problem hiding this comment.
Updated in 7dec538
| * @param {PropTypes.arrayOf(columnShape)} columns - array of data grid columns | ||
| * @returns bool | ||
| */ | ||
| const checkForColumnActions = (columns) => (!!columns.find(column => column.action)); |
There was a problem hiding this comment.
Can we rename this to hasColumnActions to be more in line with how Terra generally names booleans/functions returning booleans?
There was a problem hiding this comment.
Renamed in d050bcd
| /** | ||
| * String that specifies the init height for the resize handler to accommodate actions row. | ||
| */ | ||
| resizeHandlerInitHeight: PropTypes.string, |
There was a problem hiding this comment.
nit: Can we just call this initialHeight so we don't have to abbreviate to 'init'? It can be assumed that the height is for the resize handler since it's on the ColumnResizeHandle component.
There was a problem hiding this comment.
Renamed in 111b1e8
...-docs/src/terra-dev-site/doc/data-grid/WorklistDataGrid.1/Examples.3/ColumnActions.7.doc.mdx
Outdated
Show resolved
Hide resolved
...-docs/src/terra-dev-site/doc/data-grid/WorklistDataGrid.1/Examples.3/ColumnActions.7.doc.mdx
Outdated
Show resolved
Hide resolved
packages/terra-framework-docs/src/terra-dev-site/doc/table/Examples/TableColumnActions.doc.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sydney Combs <[email protected]>
Co-authored-by: Sydney Combs <[email protected]>
…mples/TableColumnActions.doc.mdx Co-authored-by: Sydney Combs <[email protected]>
…/WorklistDataGrid.1/Examples.3/ColumnActions.7.doc.mdx Co-authored-by: Sydney Combs <[email protected]>
…/WorklistDataGrid.1/Examples.3/ColumnActions.7.doc.mdx Co-authored-by: Sydney Combs <[email protected]>
artpark
approved these changes
Feb 26, 2024
… data-grid-add-column-action
sycombs
approved these changes
Feb 27, 2024
|
Retroactively approving. Thanks Alla! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
terra-table,terra-worklist-data-grid,terra-flowsheet-data-gridcomponents. The column actions are placed in a separate row below the header row, they have resize handle feature the same way header cells do.compact-interactive-listcomponent in this PR are only for typo fixes.Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR is a part of
UXPLATFORM-10180