This repository has been archived by the owner on May 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 72
Data grid add column actions #2024
Merged
Merged
Changes from 24 commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
c020870
column-actions-poc
adoroshk c892c62
Merge branch 'main' of https://github.com/cerner/terra-framework into…
adoroshk d8ffac9
one resize handle for both headers rows
adoroshk b47027d
added actions example
adoroshk 8be188f
lint fixes
adoroshk a9e3dc8
Merge branch 'main' of https://github.com/cerner/terra-framework into…
adoroshk f2654eb
changelogs updated
adoroshk a974186
snapshots updated
adoroshk 10028af
column actions example fix
adoroshk 3175eeb
Merge branch 'main' of https://github.com/cerner/terra-framework into…
adoroshk 0435bea
tests updated to accomodate new functionality
adoroshk 7539a62
hasColumnHeader moved to table component
adoroshk 573ecc1
removed extra line
adoroshk 9723b5c
FlowSheet actions example added
adoroshk 78a1393
actions validation added
adoroshk d6f96c1
Merge branch 'main' of https://github.com/cerner/terra-framework into…
adoroshk ab44904
snapshots updated
adoroshk 2eb2dad
added comments
adoroshk 2badaf4
padding for action cell updated
adoroshk b9d85d5
action cell buttom padding adjusted
adoroshk 453cb09
action button padding adjusted
adoroshk 4fcf085
action buttor border inset
adoroshk bc8b9a4
aria-rowindex order accomodated for double headers
adoroshk 6ba44dd
aria-rowcount and aria-rowindex updated to accomodate both - actions …
adoroshk 91d9d1e
empty action cell text added
adoroshk 7833bb9
role and scope of Column header cell updated
adoroshk 0e92550
no action cell text fixed
adoroshk 31481ea
actions moved out of <head> tag
adoroshk 13d8c7c
removed role for experiments with JAWS
adoroshk be4bdc5
revert action cell to be <th> for testing with JAWS
adoroshk ee88cac
Merge branch 'main' into data-grid-add-column-action
adoroshk 5abafd1
action cell reverted to be td, testing rowspan
adoroshk eb2a98d
rowspan reverted
adoroshk b7faa00
testing aria-owns
adoroshk 0d61fc1
testing hiding button from JAWS with aria-hidden
adoroshk 863e873
aria-hidden fix
adoroshk 54146a6
aria-owns experiment
adoroshk a9b4160
aria-owns id fixed
adoroshk 1524de6
adde aria-hidden to action td
adoroshk 079d1fc
moved aria-hidden to button to test with JAWS
adoroshk 81519f2
try if action owns resize handle helps
adoroshk 2ae6a5c
resize handle id description added
adoroshk 2c0738a
typos fixes and snapshot updates
adoroshk b279179
Column header cell jest tests added
adoroshk ddb7ed4
Column header jest tests added
adoroshk 2743ad9
console.log removed from tests
adoroshk 6653d5f
worklist data grid header keyboard navigation
adoroshk 98e796e
Merge branch 'main' of https://github.com/cerner/terra-framework into…
adoroshk e56c6d6
docs updated
adoroshk 51dc715
removed rowHeaders
adoroshk 4b9ea74
reverting headers
adoroshk c275fe0
cell headers fix
adoroshk 0842500
updare wdg wdio snapshots per shaddow in pinned column
adoroshk 1715008
column action WDG wdio tests added
adoroshk 798d5ef
wdio snapshots for fusion and lowlight themes added
adoroshk 9098f6d
wdio tests for data grid fixed, screenshots updated
adoroshk 09aa9ae
aria-owns condition changed to isResizeHandleActive
adoroshk 3eb848b
flowsheet wdio screenshots updated per shadow in pinned columns
adoroshk 79402c7
table wdio screenshots updated per pinned columns shaddow update
adoroshk 3faf2a7
test if owning resize handle only for actions row works with JAWS
adoroshk 9f5f2c7
passed active row index
adoroshk f0a2ea9
first row index fixed for data grid with hidden headers
adoroshk fe8ff94
jest tests updated
adoroshk 571eb93
wdio snapshots reverted
adoroshk eaca6e9
changed action button focuing to be consistent with header button
adoroshk d10c706
Left arrow on action button consistent with header button
adoroshk 8f97e91
removed unused prop, jupdated snapshots
adoroshk 347e44b
ownsResizeHandle prop added
adoroshk 3da2868
button setCallback fix, jest snapsots updated per new prop
adoroshk c6a5441
snapshots updated
adoroshk 0ef5e05
ownsResizeHandle prop removed from header row cell as it doesn't help…
adoroshk caa14ad
snapshots updated
adoroshk ef6dc99
fixes col index shift in row selection
adoroshk 2c3edc5
activeColumnIndex prop reverted, focusedColIndex removed
adoroshk 9f7cbbc
Merge branch 'main' of https://github.com/cerner/terra-framework into…
adoroshk e6b094a
reverted fix for col index shift
adoroshk f27b915
regenerated wdio resize handle screenshots to see if it helps with fa…
adoroshk d5a3dde
Merge branch 'main' into data-grid-add-column-action
sdadn c51e7e2
updated snapshots
sdadn 8184555
worklist data grid wdio snapshots updated test
adoroshk 5b6c20d
fix resize handle init height
adoroshk b23678f
data-grid snapshots updated
adoroshk e08e64c
Merge branch 'main' into data-grid-add-column-action
adoroshk 07b3fa1
jest snapshots updated
adoroshk 77f5bcd
Update CHANGELOG.md
sdadn 07ab860
Update CHANGELOG.md
sdadn ec72582
Update CHANGELOG.md
sdadn 14cfc7a
Update packages/terra-data-grid/src/DataGrid.jsx
adoroshk 95bd160
Update packages/terra-table/src/subcomponents/ColumnHeader.jsx
adoroshk cd59483
Update packages/terra-framework-docs/src/terra-dev-site/doc/table/Exa…
adoroshk bb935f5
Update packages/terra-framework-docs/src/terra-dev-site/doc/data-grid…
adoroshk e9bb251
Update packages/terra-framework-docs/src/terra-dev-site/doc/data-grid…
adoroshk 7dec538
changelog fix
adoroshk d050bcd
checkForColumnActions renamed to hasColumnActions
adoroshk 111b1e8
resizeHandlerInitHeight renamed to initialHeight
adoroshk 0e2ca28
Merge branch 'main' of https://github.com/cerner/terra-framework into…
adoroshk bf7ea04
snapshot updated
adoroshk c6f182c
Merge branch 'main' into data-grid-add-column-action
adoroshk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (for consistency):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 7dec538