This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-application-links] add onTabClick optional property to terra-application-links interface #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenk2
approved these changes
Apr 3, 2024
sycombs
suggested changes
Apr 3, 2024
| @@ -11,6 +11,11 @@ it('should render ApplicationTabs with links and alignment', () => { | |||
| expect(wrapper).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| it('should render ApplicationTabs with links and alignment and onTabClick handler', () => { | |||
| const wrapper = enzyme.shallow(<div><ApplicationTabs links={testLinkConfig} alignment="start" onTabClick={() => {}} /></div>); | |||
| expect(wrapper).toMatchSnapshot(); | |||
There was a problem hiding this comment.
Can we have a test that onTabClick is called when clicking the tab and avoid using snapshots? Here is an example:
Co-authored-by: Sydney Combs <[email protected]>
…r/terra-framework into terra-application-links-ontabclick
sycombs
approved these changes
Apr 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Would like to add new property to provide an ability to add custom handler on link click.
What was changed:
Expose onTabClick property to a public interface of terra-application-links.
Change logic to trigger the callback when it's provided
Why it was changed:
There is a need to pass a callback function when link clicked
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-XXXX
Thank you for contributing to Terra.
@cerner/terra