This repository has been archived by the owner on May 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[terra-application-links] add onTabClick optional property to terra-application-links interface #2113
[terra-application-links] add onTabClick optional property to terra-application-links interface #2113
Changes from 4 commits
9b1d1fb
9d3d7ff
bf9eb6e
e597ce8
dbb9b5f
76db619
737eb4b
9ebce0b
cbcfa8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a test that onTabClick is called when clicking the tab and avoid using snapshots? Here is an example:
terra-framework/packages/terra-file-path/tests/jest/FilePath.test.jsx
Line 71 in 7a086d9