This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-folder-tree] Fix axe invalid aria attribute and 400% browser zoom #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanxavierm
approved these changes
May 6, 2024
sugan2416
reviewed
May 6, 2024
| @@ -1,6 +1,5 @@ | |||
| :local { | |||
| .content-wrapper { | |||
| position: relative; | |||
| width: 300px; | |||
There was a problem hiding this comment.
Can we confirm with consumer if zoom issue occurs with similar wrapper width?
There was a problem hiding this comment.
folder-tree component has 100% of width set, so it adjusts to the screen size. Here the example has fixed size of 300px. so updated this.
Thanks
sugan2416
approved these changes
May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Updated aria-control label.
Removed default width for the folder tree example
Why it was changed:
In 400% browser zoom, some of the folders are hiding from the screen. Therefor user don't have access to some folders and they can't be accessed.
Axe issues - Invalid ARIA attribute value: aria-controls="Folder" in the toolbar 'expand all and collapse all' section
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10399-
Thank you for contributing to Terra.
@cerner/terra