Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-folder-tree] Fix axe invalid aria attribute and 400% browser zoom #2153

Merged
merged 2 commits into from
May 7, 2024
Merged

[terra-folder-tree] Fix axe invalid aria attribute and 400% browser zoom #2153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15afaea
Update: Fix axe invalid aria attribute, 400% browser zoom
MadanKumarGovindaswamy May 6, 2024
8427d81
update: changelog
MadanKumarGovindaswamy May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/terra-folder-tree/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* Changed
* Updated the radio button hover style to be distinct from row hover.
* Fixed axe issue for wrong aria-control value.

## 1.3.0 - (April 23, 2024)

Expand Down
2 changes: 1 addition & 1 deletion packages/terra-folder-tree/src/FolderTree.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ const FolderTree = ({
/>
<Toolbar
align="end"
ariaControls={title}
ariaControls={folderTreeID}
ariaLabel={title}
>
<Button
Expand Down
3 changes: 3 additions & 0 deletions packages/terra-framework-docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Changed
* Updated `terra-folder-tree` example styles.

## 1.85.0 - (May 1, 2024)

* Changed
Expand Down
1 change: 0 additions & 1 deletion ...-framework-docs/src/terra-dev-site/doc/folder-tree/Examples.2/BasicFolderTree.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
:local {
.content-wrapper {
position: relative;
width: 300px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm with consumer if zoom issue occurs with similar wrapper width?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folder-tree component has 100% of width set, so it adjusts to the screen size. Here the example has fixed size of 300px. so updated this.
Thanks

}
}
Loading