Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile and .dockerignore #35

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

jcadam14
Copy link
Contributor

@jcadam14 jcadam14 commented Jan 22, 2024

Closes #15

To test, run the following commands from the root of the repo:

  • docker build -t filing-api .
  • docker run -it -d --name current-filing-api -p 8383:8888 filing-api
  • curl -v localhost:8383/v1/filing/123/submissions/1 -F 'file=@./alembic.ini' (currently this endpoint doesn't do anything so this is just showing we can hit it, you can use any file here)
  • docker logs current-filing-api to verify a 202 Accepted was received

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit c8e7743 into main Jan 24, 2024
3 checks passed
@lchen-2101 lchen-2101 deleted the 15-dockerize-filing-api_v2 branch January 24, 2024 17:29
@jcadam14 jcadam14 restored the 15-dockerize-filing-api_v2 branch January 24, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize filing-api
2 participants