Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Fix acceptance tests via gc() #1078

Merged
merged 5 commits into from
Apr 4, 2024
Merged

[R] Fix acceptance tests via gc() #1078

merged 5 commits into from
Apr 4, 2024

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Apr 3, 2024

Fixes #1060

Adding a call to gc() seems to fix the issue.

@ebezzi ebezzi marked this pull request as ready for review April 3, 2024 15:52
pablo-gar
pablo-gar suggested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@pablo-gar pablo-gar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best practice and style is to use another on.exit() call after the census$close() one

on.exit(census$close(), add = TRUE)
on.exit(gc(verbose = TRUE, reset = FALSE, full = TRUE), add = TRUE)

see https://testthat.r-lib.org/articles/test-fixtures.html

@ebezzi ebezzi requested a review from pablo-gar April 3, 2024 17:11
@ebezzi ebezzi merged commit 07d0f43 into main Apr 4, 2024
2 checks passed
@ebezzi ebezzi deleted the ebezzi/debug-r-acceptance branch April 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-gar pablo-gar pablo-gar approved these changes

@prathapsridharan prathapsridharan prathapsridharan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[r] Add limits to acceptance tests in R
3 participants
@ebezzi @prathapsridharan @pablo-gar