Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builder] additional unit tests for builder #1085

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

bkmartinjr
Copy link
Contributor

@bkmartinjr bkmartinjr commented Apr 3, 2024

Changes:

  • More coverage of build() tests, including all supported X array formats
  • add explicit test of the data copy (to s3) functions

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (f2d19a7) to head (c3ccd92).
Report is 1 commits behind head on main.

❗ Current head c3ccd92 differs from pull request most recent head bc329e2. Consider uploading reports for the commit bc329e2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   90.65%   90.98%   +0.33%     
==========================================
  Files          76       77       +1     
  Lines        5873     5926      +53     
==========================================
+ Hits         5324     5392      +68     
+ Misses        549      534      -15     
Flag Coverage Δ
unittests 90.98% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkmartinjr bkmartinjr marked this pull request as ready for review April 4, 2024 01:46
Copy link
Contributor

@prathapsridharan prathapsridharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkmartinjr bkmartinjr merged commit 2b279be into main Apr 4, 2024
13 checks passed
@bkmartinjr bkmartinjr deleted the bkmartinjr/more-builder-unit-tests branch April 4, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants