Implement Census Visium Builder Prototype #1165
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathapsridharan
force-pushed
the
psridharan/census-builder-spatial
branch
2 times, most recently
from
66eb170
to
486a2f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 91.11% 90.46% -0.66%
==========================================
Files 77 77
Lines 5922 5933 +11
==========================================
- Hits 5396 5367 -29
- Misses 526 566 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
prathapsridharan
force-pushed
the
psridharan/census-builder-spatial
branch
from
c4ac2b5
to
c76aae1
Compare
prathapsridharan
force-pushed
the
psridharan/census-builder-spatial
branch
from
049f00d
to
44c1109
Compare
ivirshup
reviewed
Jul 12, 2024
| # TODO (spatial): tiledbsoma pin to a PyPI release is temporarily commented out in favor git commit pin | ||
| # "tiledbsoma==1.9.3", | ||
| # TODO (spatial): Pin tiledbsoma dependency to an actual released version after tiledbsoma spatial code has been released | ||
| "tiledbsoma @ git+https://github.com/single-cell-data/TileDB-SOMA.git@9eb540f#egg=tiledbsoma&subdirectory=apis/python/", |
There was a problem hiding this comment.
Suggested change
| "tiledbsoma @ git+https://github.com/single-cell-data/TileDB-SOMA.git@9eb540f#egg=tiledbsoma&subdirectory=apis/python/", | |
| "tiledbsoma @ git+https://github.com/single-cell-data/TileDB-SOMA.git@spatial#egg=tiledbsoma&subdirectory=apis/python/", |
Is there a reason you pin to this specific commit rather point at the spatial branch?
I believe the branch is being rebased, so specific commits get deleted.
ivirshup
changed the title
ivirshup
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encapsulates a prototype of the
census builderand integrate changes intiledbsomaandsomacoreas it relates to spatial. As such this PR will be added to and evolve and therefore will remain in DRAFT mode