Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Update scvi pipeline for the June LTS training #1173

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented May 31, 2024

No description provided.

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (c18c1a9) to head (48670ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files          77       77           
  Lines        5902     5902           
=======================================
  Hits         5378     5378           
  Misses        524      524           
Flag Coverage Δ
unittests 91.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ebezzi ebezzi marked this pull request as ready for review June 4, 2024 20:23
@@ -19,7 +21,7 @@ model:
filename: "scvi.model"
n_hidden: 512
n_latent: 50
n_layers: 1
n_layers: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for incrementing n_layers? Apologies if you have already addressed this in our synchronous meeting and I missed the point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was determined during the training phase last year, but I forgot to update it in the configuration file.

@ebezzi ebezzi merged commit 8d1e103 into main Jun 28, 2024
15 checks passed
@ebezzi ebezzi deleted the ebezzi/scvi-changes-june-lts branch June 28, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants