Fix a dead-lock problem in NodeProcessor::Close(). Closes #42

chengshiwen · Aug 21, 2024 · 60be0a7 · 60be0a7
1 parent 71cb30c
commit 60be0a7
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/services/hh/node_processor.go b/services/hh/node_processor.go
@@ -107,16 +107,18 @@ func (n *NodeProcessor) Open() error {
 // When closed it will not accept hinted-handoff data.
 func (n *NodeProcessor) Close() error {
 	n.mu.Lock()
-	defer n.mu.Unlock()
 
 	if n.done == nil {
 		// Already closed.
+		n.mu.Unlock()
 		return nil
 	}
 
 	close(n.done)
-	n.wg.Wait()
 	n.done = nil
+	n.mu.Unlock()
+
+	n.wg.Wait()
 
 	return n.queue.Close()
 }