Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commits #1

Merged
merged 10 commits into from
Feb 25, 2025
Merged

First commits #1

merged 10 commits into from
Feb 25, 2025

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Feb 21, 2025

🗣 Description

This pull request contains the first commits for this repo, which creates a GitHub Action to disable AppArmor on the GitHub runner.

💭 Motivation and context

This is a better (less janky) solution to the AppArmor woes than cisagov/skeleton-ansible-role#216. We are also already taxing the free GitHub runners, and I have seen failures in the steps added in cisagov/skeleton-ansible-role#216. This solution should tax the runners a bit less.

It is also worth noting that lot of folks (me included) are of the opinion that AppArmor shouldn't be enabled in the GitHub runners.

🧪 Testing

This change is tested in cisagov/skeleton-ansible-role#223.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.
  • Create v1.0 and v1 tags.

@jsf9k jsf9k self-assigned this Feb 21, 2025
@jsf9k jsf9k marked this pull request as ready for review February 21, 2025 16:37
@jsf9k jsf9k requested a review from a team February 21, 2025 16:37
@jsf9k jsf9k added documentation This issue or pull request improves or adds to documentation version bump This issue or pull request increments the version number labels Feb 21, 2025
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one tiny thang. 👍

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔ One minor suggestion for your consideration.

This link was mistakenly changed by gh skeleton clone.
@jsf9k jsf9k merged commit 437d94f into develop Feb 25, 2025
4 checks passed
@jsf9k jsf9k deleted the first-commits branch February 25, 2025 18:52
@jsf9k jsf9k restored the first-commits branch February 25, 2025 18:54
@jsf9k jsf9k deleted the first-commits branch February 25, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants