-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First commits #1
Merged
Merged
+244
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dv4harr10
approved these changes
Feb 21, 2025
dav3r
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one tiny thang. 👍
These were copied from cisagov/skeleton-packer. Also add semver as a dependency since it is required for the bump-version script.
Co-authored-by: dav3r <[email protected]>
mcdonnnj
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔ One minor suggestion for your consideration.
Co-authored-by: Nick M <[email protected]>
dav3r
approved these changes
Feb 24, 2025
This link was mistakenly changed by gh skeleton clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
This issue or pull request improves or adds to documentation
version bump
This issue or pull request increments the version number
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request contains the first commits for this repo, which creates a GitHub Action to disable AppArmor on the GitHub runner.
💭 Motivation and context
This is a better (less janky) solution to the AppArmor woes than cisagov/skeleton-ansible-role#216. We are also already taxing the free GitHub runners, and I have seen failures in the steps added in cisagov/skeleton-ansible-role#216. This solution should tax the runners a bit less.
It is also worth noting that lot of folks (me included) are of the opinion that AppArmor shouldn't be enabled in the GitHub runners.
🧪 Testing
This change is tested in cisagov/skeleton-ansible-role#223.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist
v1.0
andv1
tags.