Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AppArmor before running Molecule tests #223

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Feb 21, 2025

🗣 Description

This pull request modifies the build.yml workflow to leverage cisagov/action-disable-apparmor to disable AppArmor before running the Molecule tests.

💭 Motivation and context

This is a better (less janky) solution to the AppArmor woes than #216. We are also already taxing the free GitHub runners, and I have seen failures in the steps added in #216. This solution should tax the runners a bit less.

It is also worth noting that lot of folks (me included) are of the opinion that AppArmor shouldn't be enabled in the GitHub runners.

Resolves #215.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code labels Feb 21, 2025
@jsf9k jsf9k self-assigned this Feb 21, 2025
@jsf9k jsf9k marked this pull request as ready for review February 21, 2025 16:41
@jsf9k jsf9k requested a review from a team February 21, 2025 16:51
@jsf9k jsf9k added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Feb 21, 2025
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Status: In Progress
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

Remove apt-get purge of firefox and passt when possible
4 participants