Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new-logic 2/X: Typesafe settings #162

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

new-logic 2/X: Typesafe settings #162

wants to merge 6 commits into from

Conversation

robojumper
Copy link
Contributor

@robojumper robojumper commented Mar 8, 2024 •
edited
Loading

  • Removes the Settings class to separate data fetching from actual options/settings concerns
  • Bases Settings type on options command rather than human readable name
    • Avoids breakage when settings get renamed
    • More closely matches ssrando-internals
    • Works better with IDEs hints, autocompletion
  • Automatically generates a type checked Settings interface based on upstream data, which is extended with preliminary support for future features
  • Drops support for pre-2.0 settings

@robojumper robojumper mentioned this pull request Mar 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robojumper