Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18 simplify author and maintainer name and email into one field each #22

Closed
wants to merge 42 commits into from

Conversation

florianm
Copy link
Contributor

As per #18 - template code from ckan's additional fields works nicely at the cost of introducing usage of pkg_dict and breaking the sequential handling of fields.

@wardi
Copy link
Contributor

wardi commented Jan 5, 2015

How about a more general solution?

We could have a 'display_field': false option on author_email and maintainer_email then add a custom display snippet for author and maintainer that would include the email link like this if present.

Florian Mayer added 2 commits January 6, 2015 09:54
…e, email gets display snippet:email.html with display_email_name_field set to respective name
@florianm
Copy link
Contributor Author

florianm commented Jan 6, 2015

Actually there's an even simpler way. "author" gets hidden with 'display_field': false, and "author_email" gets rendered as name (if no email given), email (if no name given) or name as email link (if both given) via "display_email_name_field": "author". No template changes necessary, so that scales up nicely.

Also I'll close this PR and submit a cleaner PR shortly. Note to self, no merges before coffee.

@florianm
Copy link
Contributor Author

florianm commented Jan 6, 2015

Replaced with a cleaner PR #23

@florianm florianm closed this Jan 6, 2015
@florianm florianm deleted the 18-author-maintainer-fields branch January 6, 2015 02:31
sagargg pushed a commit to FCSCOpendata/ckanext-scheming that referenced this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants