-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#18 combine name and email display #23
base: master
Are you sure you want to change the base?
Conversation
…ication with their corresponding email fields
we still need the thing that checks for |
Strangely, |
Hmm. doesn't seem to hide the fields when I try it. |
Found why it works on my end - I'm still using my much too clever additional info display snippet with special treatment for author and maintainer fields. |
@florianm ok, should we close this too, or will you add the display_snippet is None check to this PR? |
@wardi sorry I got sidetracked - I will add the check to this PR today. Edit: soon. |
@wardi added a property "hide_field", formatted additional_info.html for readability and added check for hide_field there, added email example to camel_photos.json. Up for discussion:
|
@wardi I need to double-check whether dataset notes are hidden inadvertently, sorry that's one thing I might have clobbered last minute! |
@wardi there's travis errors with the solr server that I'm sure I didn't touch. Any ideas whether that's a problem to do with my changed templates? |
As discussed in (messy and closed) PR #22 this PR combines the display of name/email combo fields by hiding the name field, and letting the email field render the email address (if given) with the specified name field (if given). Addresses #18