Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor deletion warning message #49

Merged
merged 8 commits into from
Dec 6, 2023
Merged

chore: refactor deletion warning message #49

merged 8 commits into from
Dec 6, 2023

Conversation

milldr
Copy link
Member

@milldr milldr commented Dec 6, 2023

what

  • Changed deletion warning to the following

Caution

Terraform will delete resources!
This plan contains resource delete operations. Please check the plan result very carefully.

why

  1. Cleaner warning message
  2. There's currently a bug in GitHub Summary with emojis (⚠️ )

references

  • n/a

@milldr milldr requested review from a team as code owners December 6, 2023 19:55
@milldr milldr added the minor New features that do not break anything label Dec 6, 2023
@milldr milldr requested a review from a team as a code owner December 6, 2023 20:09
@milldr milldr enabled auto-merge December 6, 2023 20:49
@milldr milldr merged commit 4603974 into main Dec 6, 2023
46 of 48 checks passed
@milldr milldr deleted the refactor-warning branch December 6, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants