-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EN] add Runtime #2033
[EN] add Runtime #2033
Conversation
Signed-off-by: Akshat Sharma <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks, @akshatcoder-hash. We are still working on pod and stateless apps but will tackle this PR as soon as we finish those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. I made a few small edits, added semantic line breaks, hyperlinked terms in the definition directly.
I'll need a technical review to review as well, though.
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and a couple nits:
Co-authored-by: Nate W. <[email protected]> Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Nate W. <[email protected]> Signed-off-by: Catherine Paganini <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hei @akshatcoder-hash,
thanks for the contribution :) This one is a little bit tricky because runtime is something that is not only a cloud native term. We had a discussion about this among the maintainers and decided that we need to distinguish between runtime in general and runtime in the context of cloud native. In the context of cloud native, we refer to runtime being the container runtime.
I guess this makes it a little bit easier for you also because I recognized you were mixing containers, Kubernetes, and runtime properties all together when describing the term. But we really need to be precise here.
Please correct me if I am wrong with anything @seokho-son @jihoon-seo @idvoretskyi
Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Nate W. <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
hey @iamNoah1! |
We'll need to give it another pass. Thanks for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshatcoder-hash thanks a lot for your patience and contribution. I see that you added some suggestions, but there were some conversations that you just resolved without changing anything. So I would ask you to please take a look at those again. I understand if it is challenging and if you are not able to come up with an accurate modification. But please be fair and communicate it accordingly. Also @nate-double-u and @castrojo maybe you could check if my comments are accurate or completely off.
Yeah we need to resolve lines 22-25 to be more precise. I also looked in the OCI spec and found this: https://github.com/opencontainers/runtime-spec/blob/main/glossary.md#runtime Thinking aloud, shouldn't this definition be a subset of that specification and link to it? Something like: (after the definition of normal runtime) "A cloud native container runtime specifically implements this specification to ensure consistent consumption around the ecosystem. They read the configuration files from a bundle, uses that information to create a container, launches a process inside the container, and performs other lifecycle actions." "Common runtimes include docker ..." and there's a list of things on the opencontainers github org that we can also deep link to. I can take a stab at a diff if you'd like! |
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content/en/runtime.md
Outdated
The runtime is scoped to only handle the lifecycle of the containers. | ||
User-facing features, such as scaling and service discovery, fault tolerance, etc., are managed by the orchestrator or some other high-level tool that interfaces with the runtime. | ||
|
||
Without a container runtime, the user would have to manually handle the container lifecycle, interface directly with cgroups and namespaces in the kernel, and handle hardware resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshatcoder-hash did you already add the simplification?! Instead of throwing in cgroups and namespaces and kernel, we could just say operating system.
friendly ping @CathPag and @akshatcoder-hash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to resolve some points.
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some last suggestions to be more neat and accurate. Please take a look @CathPag @castrojo @nate-double-u
Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one question remains and this can be merged.
Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last suggestion
Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we made it :)
* [EN] New Term- Runtime Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W. <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W. <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W. <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Jorge O. Castro <[email protected]> Signed-off-by: Noah Ispas <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * fix: cut out examples Signed-off-by: Jorge O. Castro <[email protected]> * fix: add section on the problem it addresses Signed-off-by: Jorge O. Castro <[email protected]> * Update runtime.md removed empty lines Signed-off-by: Noah Ispas <[email protected]> * Update content/en/runtime.md Signed-off-by: Noah Ispas <[email protected]> * Update content/en/runtime.md Signed-off-by: Noah Ispas <[email protected]> * Update runtime.md Fix spelling, the rest depends on this landing: cncf#2244 Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> * add cgroups, namespaces, and orchestrator to wordlist Signed-off-by: Jorge O. Castro <[email protected]> * Update content/en/runtime.md Signed-off-by: Nate W <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Nate W <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Nate W <[email protected]> * Update content/en/runtime.md Co-authored-by: Nate W <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Akshat Sharma <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Noah Ispas <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Noah Ispas <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Noah Ispas <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> * Update runtime.md Signed-off-by: Catherine Paganini <[email protected]> * Update content/en/runtime.md Co-authored-by: Catherine Paganini <[email protected]> Signed-off-by: Noah Ispas <[email protected]> * Update content/en/runtime.md Co-authored-by: Noah Ispas <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> --------- Signed-off-by: Akshat Sharma <[email protected]> Signed-off-by: Catherine Paganini <[email protected]> Signed-off-by: Noah Ispas <[email protected]> Signed-off-by: Jorge O. Castro <[email protected]> Signed-off-by: Nate W <[email protected]> Co-authored-by: Catherine Paganini <[email protected]> Co-authored-by: Nate W. <[email protected]> Co-authored-by: Noah Ispas <[email protected]> Co-authored-by: Jorge O. Castro <[email protected]>
Describe your changes
Added a new term - Runtime
Related issue number or link (ex:
resolves #issue-number
)resolves #1892
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.