Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] add Runtime #2033

Merged
merged 58 commits into from
Aug 15, 2023
Merged

[EN] add Runtime #2033

merged 58 commits into from
Aug 15, 2023

Conversation

akshatcoder-hash
Copy link
Contributor

Describe your changes

Added a new term - Runtime

Related issue number or link (ex: resolves #issue-number)

resolves #1892

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Akshat Sharma <[email protected]>
@netlify
Copy link

netlify bot commented May 12, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit b7b55fc
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/64da2b91cba11d0008e15d9f
😎 Deploy Preview https://deploy-preview-2033--cncfglossary.netlify.app/runtime
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/en for English label May 12, 2023
@CathPag
Copy link
Collaborator

CathPag commented May 18, 2023

Thanks, @akshatcoder-hash. We are still working on pod and stateless apps but will tackle this PR as soon as we finish those.

Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. I made a few small edits, added semantic line breaks, hyperlinked terms in the definition directly.

I'll need a technical review to review as well, though.

content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
akshatcoder-hash and others added 4 commits May 27, 2023 01:27
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
@nate-double-u nate-double-u self-requested a review May 31, 2023 03:16
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and a couple nits:

content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
CathPag and others added 3 commits June 13, 2023 09:34
Co-authored-by: Nate W. <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Nate W. <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hei @akshatcoder-hash,

thanks for the contribution :) This one is a little bit tricky because runtime is something that is not only a cloud native term. We had a discussion about this among the maintainers and decided that we need to distinguish between runtime in general and runtime in the context of cloud native. In the context of cloud native, we refer to runtime being the container runtime.

I guess this makes it a little bit easier for you also because I recognized you were mixing containers, Kubernetes, and runtime properties all together when describing the term. But we really need to be precise here.

Please correct me if I am wrong with anything @seokho-son @jihoon-seo @idvoretskyi

content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
akshatcoder-hash and others added 2 commits June 19, 2023 00:01
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Nate W. <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
@nate-double-u nate-double-u changed the title [EN] New Term- Runtime [EN] add Runtime Jun 19, 2023
@akshatcoder-hash
Copy link
Contributor Author

hey @iamNoah1!
Thanks for the suggestion. I have resolved the conversation as of now. Do let me know if there are any additional suggestions

@CathPag
Copy link
Collaborator

CathPag commented Jun 22, 2023

We'll need to give it another pass. Thanks for your patience.

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshatcoder-hash thanks a lot for your patience and contribution. I see that you added some suggestions, but there were some conversations that you just resolved without changing anything. So I would ask you to please take a look at those again. I understand if it is challenging and if you are not able to come up with an accurate modification. But please be fair and communicate it accordingly. Also @nate-double-u and @castrojo maybe you could check if my comments are accurate or completely off.

@castrojo
Copy link
Member

Yeah we need to resolve lines 22-25 to be more precise. I also looked in the OCI spec and found this: https://github.com/opencontainers/runtime-spec/blob/main/glossary.md#runtime

Thinking aloud, shouldn't this definition be a subset of that specification and link to it? Something like:

(after the definition of normal runtime)

"A cloud native container runtime specifically implements this specification to ensure consistent consumption around the ecosystem. They read the configuration files from a bundle, uses that information to create a container, launches a process inside the container, and performs other lifecycle actions."

"Common runtimes include docker ..." and there's a list of things on the opencontainers github org that we can also deep link to. I can take a stab at a diff if you'd like!

akshatcoder-hash and others added 5 commits July 24, 2023 21:13
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/en/runtime.md Outdated Show resolved Hide resolved
The runtime is scoped to only handle the lifecycle of the containers.
User-facing features, such as scaling and service discovery, fault tolerance, etc., are managed by the orchestrator or some other high-level tool that interfaces with the runtime.

Without a container runtime, the user would have to manually handle the container lifecycle, interface directly with cgroups and namespaces in the kernel, and handle hardware resources.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshatcoder-hash did you already add the simplification?! Instead of throwing in cgroups and namespaces and kernel, we could just say operating system.

@iamNoah1
Copy link
Collaborator

friendly ping @CathPag and @akshatcoder-hash

Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to resolve some points.

content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
@CathPag CathPag removed the Edits ✅ label Aug 2, 2023
iamNoah1 and others added 3 commits August 11, 2023 11:45
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some last suggestions to be more neat and accurate. Please take a look @CathPag @castrojo @nate-double-u

content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
CathPag and others added 7 commits August 11, 2023 09:27
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one question remains and this can be merged.

content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
content/en/runtime.md Outdated Show resolved Hide resolved
Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion

content/en/runtime.md Outdated Show resolved Hide resolved
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we made it :)

@iamNoah1 iamNoah1 merged commit 2555437 into cncf:main Aug 15, 2023
6 checks passed
Fionn88 pushed a commit to Fionn88/glossary that referenced this pull request Sep 15, 2023
* [EN] New Term- Runtime

Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W. <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W. <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W. <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Jorge O. Castro <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* fix: cut out examples

Signed-off-by: Jorge O. Castro <[email protected]>

* fix: add section on the problem it addresses

Signed-off-by: Jorge O. Castro <[email protected]>

* Update runtime.md

removed empty lines

Signed-off-by: Noah Ispas <[email protected]>

* Update content/en/runtime.md

Signed-off-by: Noah Ispas <[email protected]>

* Update content/en/runtime.md

Signed-off-by: Noah Ispas <[email protected]>

* Update runtime.md

Fix spelling, the rest depends on this landing: cncf#2244

Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>

* add cgroups, namespaces, and orchestrator to wordlist

Signed-off-by: Jorge O. Castro <[email protected]>

* Update content/en/runtime.md

Signed-off-by: Nate W <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Nate W <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Nate W <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Nate W <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Akshat Sharma <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

* Update runtime.md

Signed-off-by: Catherine Paganini <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Catherine Paganini <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* Update content/en/runtime.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>

---------

Signed-off-by: Akshat Sharma <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>
Signed-off-by: Nate W <[email protected]>
Co-authored-by: Catherine Paganini <[email protected]>
Co-authored-by: Nate W. <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>
Co-authored-by: Jorge O. Castro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[New term] Runtime
5 participants