Update some dependencies #3210
Update some dependencies #3210
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Okabe-Junya
force-pushed
the
update-dependencies
branch
2 times, most recently
from
f7ae7ef
to
b334db7
Compare
Okabe-Junya
added
maintainers
Okabe-Junya
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
Signed-off-by: Junya Okabe <[email protected]>
Signed-off-by: Junya Okabe <[email protected]>
Signed-off-by: Junya Okabe <[email protected]> Revert "chore: submodule update (v0.10.0)" This reverts commit 6618629.
Signed-off-by: Junya Okabe <[email protected]>
Okabe-Junya
force-pushed
the
update-dependencies
branch
from
9705c2c
to
e397d03
Compare
Signed-off-by: Junya Okabe <[email protected]>
Signed-off-by: Junya Okabe <[email protected]>
There was a problem hiding this comment.
For some reason the Browse by Tags page doesn't seem to work properly. When I do "Select All" I only see one results. Could you figure out which change you made caused this?
Signed-off-by: Junya Okabe <[email protected]>
|
Ah, great point! Thank you for bringing that up, @cjyabraham . I've been looking into this bug, and while I don’t have a complete explanation yet, it seems to occur when updating Hugo from v0.122 to v0.123. Since v0.123 includes some breaking changes, it might take a bit more time to fully investigate. For this PR, I've addressed the bug by stopping the update at v0.122, and it seems to be working well now. |
There was a problem hiding this comment.
Related issue number or link (ex:
resolves #issue-number)close #3189
This contributes to #3189 without closing it -- please update the opening comment to reflect this. Issue #3189 is also about updating Docsy, which is where the heavy lifting will occur. The current version of Docsy used in this repo is 3 years old.
If @cjyabraham is happy with this update, I'm willing to give it a thumbs up too.
| <!-- Google Tag Manager --> | ||
| <script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start': |
There was a problem hiding this comment.
@cjyabraham - is GTM still being used by this site?
There was a problem hiding this comment.
Whenever Docsy is update in a followup PR, consideration should be given to eliminating this partial override, and moving any customization to, say, layouts/partials/hooks/head-end.html if that makes sense (or maybe a custom layouts/partials/script.html file).
/cc @cjyabraham
|
Thank you for your comment, @chalin! As you suggested, I've removed the link to the Issue, so 3189 won't be closed when this PR is merged. Additionally, I'd like to merge this PR as it is, separate from the docsy update. I think it’s useful as a maintenance PR, so I'd like to go ahead with merging it, thanks! |
|
I think this PR is ready for review / merge! Please take another look to move forward, thanks! |
Describe your changes
Related issue number or link (ex:
resolves #issue-number)ref. #3189
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".