Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some dependencies #3210

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Update some dependencies #3210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
49b8761
chore: update some dependencies
Okabe-Junya Jun 28, 2024
cfc7fac
fix: deprecated error
Okabe-Junya Jun 28, 2024
989a1e6
chore: submodule update (v0.10.0)
Okabe-Junya Jun 28, 2024
e397d03
chore: update dependencies
Okabe-Junya Jun 28, 2024
5570493
update: package.json
Okabe-Junya Jul 23, 2024
9a96812
fix: layouts/partials/head.html
Okabe-Junya Jul 23, 2024
5273717
chore: pin hugo-extended
Okabe-Junya Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions layouts/partials/head.html
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever Docsy is update in a followup PR, consideration should be given to eliminating this partial override, and moving any customization to, say, layouts/partials/hooks/head-end.html if that makes sense (or maybe a custom layouts/partials/script.html file).

/cc @cjyabraham

Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,7 @@
{{ partial "hooks/head-end.html" . }}
<!--To comply with GDPR, cookie consent scripts places in head-end must execute before Google Analytics is enabled -->
{{ if hugo.IsProduction }}
{{ if hasPrefix .Site.GoogleAnalytics "G-"}}
{{ template "_internal/google_analytics.html" . }}
{{ else }}
{{ template "_internal/google_analytics_async.html" . }}
{{ end }}
{{ template "_internal/google_analytics.html" . }}

<!-- Google Tag Manager -->
<script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
Comment on lines 54 to 55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjyabraham - is GTM still being used by this site?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Expand Down
12 changes: 5 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,14 @@
"test": "npm run check:links",
"update:pkgs": "npx npm-check-updates -u"
},
"dependencies": {
"lunr-languages": "^1.9.0"
},
"devDependencies": {
"autoprefixer": "^9.8.6",
"hugo-extended": "^0.115.2",
"postcss-cli": "^7.1.2"
"autoprefixer": "^10.4.19",
"hugo-extended": "^0.122.0",
"postcss": "^8.4.38",
"postcss-cli": "^11.0.0"
},
"optionalDependencies": {
"netlify-cli": "^17.26.1",
"netlify-cli": "^17.30.0",
"npm-check-updates": "^16.14.20"
},
"enginesComment": "Ensure that engines.node value stays consistent with the project's .nvmrc",
Expand Down