Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] Update Serverless - fix links #3239

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

guillaumebernard84
Copy link
Collaborator

@guillaumebernard84 guillaumebernard84 commented Jul 22, 2024

Describe your changes

Hello, I'm updating the French translation of this term and I noticed 2 little problems with the links:

  • Line 12: a page about OCI runtime exist, it would be nice to link it.
  • Line 17: Both links are dead as PaaS and SaaS are deprecated terms. I thought deprecated terms were still accessible by direct links, but it gives a "Oops, this page doesn't exist" in the English version. So I removed the links.

Thank you

Related issue number or link (ex: resolves #issue-number)

This is a minor fix, so I didn't open an issue. Tell me if I need to open one.

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Guillaume Bernard <[email protected]>
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit de28808
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/669eb862e80a8b00087b1ce1
😎 Deploy Preview https://deploy-preview-3239--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guillaumebernard84 guillaumebernard84 changed the title fix links [EN] Update Serverless - fix links Jul 22, 2024
@guillaumebernard84 guillaumebernard84 mentioned this pull request Jul 22, 2024
2 tasks
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

(Although I am not a reviewer for English, since this PR doesn't contain technical content, I think it's okay to move forward.)

cc @jihoon-seo

@Okabe-Junya Okabe-Junya linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamNoah1 iamNoah1 merged commit 79896d4 into cncf:main Aug 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
Development

Successfully merging this pull request may close these issues.

Function as a Service (FaaS) and Serverless
4 participants