Ray Integration to Stacks #52
Conversation
There was a problem hiding this comment.
Thanks @elamaran11 for this stack. I will wait for the requested changes and then approve it.
ray-integration/README.md
Outdated
| ```bash | ||
| idpbuilder create \ | ||
| --use-path-routing \ | ||
| --p https://github.com/cnoe-io/stacks//ray-integration |
There was a problem hiding this comment.
The shorthand flag has to be -p and longhand is --package
ray-integration/README.md
Outdated
| ```bash | ||
| idpbuilder create \ | ||
| --use-path-routing \ | ||
| --p https://github.com/cnoe-io/stacks//ref-implementation |
There was a problem hiding this comment.
This command is missing multiline command format
| @@ -0,0 +1,95 @@ | |||
| # Make sure to increase resource requests and limits before using this example in production. | |||
| # For examples with more realistic resource configuration, see | |||
| # ray-cluster.complete.large.yaml and | |||
There was a problem hiding this comment.
do we have references to these files?
There was a problem hiding this comment.
No longer required, references are removed.
| apiVersion: backstage.io/v1alpha1 | ||
| kind: Location | ||
| metadata: | ||
| name: basic-example-templates | ||
| description: A collection of example templates | ||
| spec: | ||
| targets: | ||
| - ./ray-serve/template-ray-serve.yaml | ||
| --- | ||
| apiVersion: backstage.io/v1alpha1 | ||
| kind: Location | ||
| metadata: | ||
| name: basic-organization | ||
| description: Basic organization data | ||
| spec: | ||
| targets: | ||
| - ./organization/guests.yaml |
There was a problem hiding this comment.
we should template-ray-serve.yaml to : https://github.com/cnoe-io/stacks/tree/main/ref-implementation/backstage-templates/entities
OR
Remove basic-organization location and instructions to Register an existing component using catalog-info.yaml from this stack.
|
|
||
| train_config = { | ||
| "lr": 1e-3, | ||
| "epochs": 1, # artifically set low to finish quickly |
Signed-off-by: Elamaran Shanmugam <[email protected]>
Signed-off-by: Elamaran Shanmugam <[email protected]>
Signed-off-by: Elamaran Shanmugam <[email protected]>
|
@punkwalker All required changes and comments are incorporated. Please review and merge. |
This PR adds a new RAY Stack integration to Stacks. This PR includes the following: