Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PROCESSING_TIMEOUT upload error code #3522

Merged
merged 2 commits into from
Dec 3, 2024
Merged

add PROCESSING_TIMEOUT upload error code #3522

merged 2 commits into from
Dec 3, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Nov 20, 2024 •
edited
Loading

a significant number of "unknown errors" that we report to users are timing out during processing. this PR creates an error code for it, and we can later choose to display different text in gazebo for that error code

note: worker will attempt to set this error code and save everything when it gets the "soft timeout" signal. but there is no guarantee it won't be forcibly killed before it can save everything. there will still be some unknown uploads from that

sibling PR in shared: codecov/shared#431

@matt-codecov matt-codecov requested a review from a team November 20, 2024 22:06
@codecov-staging
Copy link

codecov-staging bot commented Nov 20, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 69 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 51 bytes (0.0%) ⬆️
gazebo-staging-system 5.66MB 18 bytes (0.0%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 69 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.66MB 18 bytes (0.0%) ⬆️
gazebo-production-system-esm 5.72MB 51 bytes (0.0%) ⬆️

@matt-codecov matt-codecov mentioned this pull request Nov 20, 2024
Merged
@codecov-notifications
Copy link

codecov-notifications bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3522   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14476           
  Branches     4115     4108    -7     
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
src/shared/utils/commit.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d3bbd...0cb17db. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (a9d3bbd) to head (0cb17db).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3522   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14476           
  Branches     4115     4108    -7     
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
src/shared/utils/commit.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d3bbd...0cb17db. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (a9d3bbd) to head (0cb17db).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3522   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14476           
  Branches     4115     4108    -7     
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
src/shared/utils/commit.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d3bbd...0cb17db. Read the comment docs.

@matt-codecov matt-codecov mentioned this pull request Nov 20, 2024
Closed
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 20, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
8be746f Wed, 20 Nov 2024 22:11:09 GMT Expired Expired
0cb17db Tue, 03 Dec 2024 18:56:42 GMT Cloud Enterprise

@matt-codecov matt-codecov changed the base branch from main to staging November 20, 2024 22:38
@matt-codecov matt-codecov changed the base branch from staging to main November 20, 2024 22:38
nicholas-codecov
nicholas-codecov approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it

@matt-codecov matt-codecov added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit f192e1f Dec 3, 2024
61 of 62 checks passed
@matt-codecov matt-codecov deleted the pr3522 branch December 3, 2024 18:58
@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (a9d3bbd) to head (0cb17db).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3522   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14476           
  Branches     4115     4115           
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
src/shared/utils/commit.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d3bbd...0cb17db. Read the comment docs.

This was referenced Dec 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-codecov nicholas-codecov nicholas-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matt-codecov @codecov-releaser @nicholas-codecov