Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PROCESSING_TIMEOUT upload error code #431

Merged
merged 1 commit into from
Dec 3, 2024
Merged

add PROCESSING_TIMEOUT upload error code #431

merged 1 commit into from
Dec 3, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Nov 20, 2024

a significant number of "unknown errors" that we report to users are timing out during processing. this PR creates an error code for it, and we can later choose to display different text in gazebo for that error code

note: worker will attempt to set this error code and save everything when it gets the "soft timeout" signal. but there is no guarantee it won't be forcibly killed before it can save everything. there will still be some unknown uploads from that

sibling PR in gazebo: codecov/gazebo#3522

@matt-codecov matt-codecov added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 27d6a8f Dec 3, 2024
6 checks passed
@matt-codecov matt-codecov deleted the pr431 branch December 3, 2024 22:43
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (511b553) to head (10e4737).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   90.56%   89.81%   -0.75%     
==========================================
  Files         390      324      -66     
  Lines       11768     9379    -2389     
  Branches     1974     1677     -297     
==========================================
- Hits        10658     8424    -2234     
+ Misses       1026      891     -135     
+ Partials       84       64      -20     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants