-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: useCommit doesn't always expect flags #3570
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3570 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14485 14485
Branches 4116 4109 -7
=======================================
Hits 14327 14327
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3570 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14485 14485
Branches 4109 4116 +7
=======================================
Hits 14327 14327
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3570 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14485 14485
Branches 4116 4116
=======================================
Hits 14327 14327
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3570 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14485 14485
Branches 4116 4116
=======================================
Hits 14327 14327
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 2 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 2 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Before we expect flags to always be in the commit object, but that shouldn't be the case as team plan doesn't support flags.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.