Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useCommit doesn't always expect flags #3570

Merged
merged 6 commits into from
Dec 11, 2024
Merged

fix: useCommit doesn't always expect flags #3570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49deeec
fix: useCommit doesn't always expect flags
JerrySentry Dec 11, 2024
7b7b0b4
typing
JerrySentry Dec 11, 2024
9bf5fe0
typing 2
JerrySentry Dec 11, 2024
5cec026
typing 3
JerrySentry Dec 11, 2024
61352b4
Merge branch 'main' into dec_11_fix_no_flags_team_plan
JerrySentry Dec 11, 2024
6ae8cbb
Merge branch 'main' into dec_11_fix_no_flags_team_plan
JerrySentry Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/CommitDetailPage/CommitCoverage/UploadsCard/RenderError.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ const FlagError = () => (
interface RenderErrorProps {
errors: (UploadErrorObject | null)[]
state: (typeof UploadStateEnum)[keyof typeof UploadStateEnum]
flags: string[] | null
flags: string[] | null | undefined
}

const RenderError = ({ errors, state, flags }: RenderErrorProps) => {
Expand Down
2 changes: 1 addition & 1 deletion src/services/commit/useCommit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const UploadSchema = z.object({
provider: z.string().nullable(),
createdAt: z.string(),
updatedAt: z.string(),
flags: z.array(z.string()).nullable(),
flags: z.array(z.string()).nullish(),
jobCode: z.string().nullable(),
downloadUrl: z.string(),
ciUrl: z.string().nullable(),
Expand Down
2 changes: 1 addition & 1 deletion src/shared/utils/extractUploads.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface Upload {
provider: string | null
createdAt: string
updatedAt: string
flags: string[] | null
flags?: string[] | null
jobCode: string | null
downloadUrl: string
ciUrl: string | null
Expand Down
Loading