Repair the project structure. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@Daksh14 found a small bug, I added a commit to fix it. https://ptb.discordapp.com/channels/634104110131445811/635510829499940912/694959512536481882 |
This is a mistake, I do not know why this compiles on my machine but suspect that the compiler treats it as default method, but that is just a guess based on the error message that @Weegee received. https://discordapp.com/channels/634104110131445811/635510829499940912/694958697151070258 Co-Authored-By: weegee <[email protected]>
|
Note to self in general: There are many modifiers that are public when they should just be internal and have no business being public. |
misha130
reviewed
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I moved the code over from core I misunderstood the structure and made the application project depend on the infrastructure project, when it really should have been the other way around.
@misha130 explained this to me in this thread: #9 (comment) .