Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register and Login page #9

Merged
merged 14 commits into from
Mar 27, 2020
Merged

Register and Login page #9

merged 14 commits into from
Mar 27, 2020

Conversation

misha130
Copy link
Contributor

@misha130 misha130 commented Mar 22, 2020

This closes #3 and #12

Uses Co-Design for login/register.

There is no Core Api existing so that part should be done via another PR and a PR in the core rep.

@misha130 misha130 changed the base branch from master to develop March 22, 2020 15:33
src/Application/Application.csproj Show resolved Hide resolved
src/Application/Common/Interfaces/ICoreApiService.cs Outdated Show resolved Hide resolved
src/Infrastructure/DependencyInjection.cs Show resolved Hide resolved
src/WebApp/wwwroot/lib/co-design/css/codidact.css Outdated Show resolved Hide resolved
src/Infrastructure/DependencyInjection.cs Outdated Show resolved Hide resolved
src/Infrastructure/Infrastructure.csproj Outdated Show resolved Hide resolved
src/Infrastructure/Infrastructure.csproj Outdated Show resolved Hide resolved
src/WebApp/Startup.cs Show resolved Hide resolved
misha130 and others added 2 commits March 23, 2020 13:32
Co-Authored-By: Paul Scharnofske <[email protected]>
Co-Authored-By: Paul Scharnofske <[email protected]>
This was referenced Mar 27, 2020
Copy link
Member

@luap42 luap42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I have two questions/requests

src/WebApp/Pages/Shared/_Header.cshtml Outdated Show resolved Hide resolved
src/WebApp/Pages/Account/Login.cshtml Outdated Show resolved Hide resolved
Copy link
Contributor

@asynts asynts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that we had database first which would mean that we would not use migrations.

However, I remember this being discussed somewhere and since we are very early in development, this could easily be reverted. Also we already have migrations in core so this does not seem like that was final.

This can be merged in my opinion.

@misha130 misha130 changed the title Register page Register and Login page Mar 27, 2020
@cellio
Copy link
Member

cellio commented Mar 27, 2020

Edit: It has been pointed out to me that y'all might have been discussing database migrations, not content migrations, and I misunderstood. Sorry!


Original comment:

My understanding was that we had database first which would mean that we would not use migrations.

Not sure if we're all using words the same way, so just in case...

  • We aren't currently doing anything with migrating questions from one Codidact site to another. It's widely held that cross-site migrations on SE have problems, so we need to rethink that from first principles.

  • We are allowing importing content from SE to Codidact. I've been using the word "import" for that rather than "migrate", but I think you might be talking about that here?

  • In order to support migrations from SE (and the proper attribution thereof), we need to be able to connect a Codidact user to an SE user. That's info that belongs with the user profile somewhere.

  • For MVP we definitely want to be able to do bulk imports (all questions from site X, all questions in tags A, B, C from site Y, etc -- anything you can express in SQL). We have said that for MVP it is acceptable if this doesn't have on-site tooling and is done by an admin with DB access.

  • We have not yet talked about users importing individual questions. It's not a blocker for MVP and we haven't fleshed out how it ought to work, but it's something we could have.

@luap42 luap42 merged commit 825ece3 into codidact:develop Mar 27, 2020
luap42 pushed a commit that referenced this pull request Apr 3, 2020
* Repair the project structure.

#9 (comment)

* Remove 'public' from method in interface.

This is a mistake, I do not know why this compiles on my machine but suspect
that the compiler treats it as default method, but that is just a guess based on
the error message that @Weegee received.

https://discordapp.com/channels/634104110131445811/635510829499940912/694958697151070258

Co-Authored-By: weegee <[email protected]>

* Update Infrastructure.csproj

Co-authored-by: weegee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a sign-up page.
4 participants