-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register and Login page #9
Conversation
Co-Authored-By: Paul Scharnofske <[email protected]>
Co-Authored-By: Paul Scharnofske <[email protected]>
Co-Authored-By: Paul Scharnofske <[email protected]>
…ation into register-page
Co-Authored-By: luap42 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but I have two questions/requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding was that we had database first which would mean that we would not use migrations.
However, I remember this being discussed somewhere and since we are very early in development, this could easily be reverted. Also we already have migrations in core so this does not seem like that was final.
This can be merged in my opinion.
Co-Authored-By: luap42 <[email protected]>
Edit: It has been pointed out to me that y'all might have been discussing database migrations, not content migrations, and I misunderstood. Sorry! Original comment:
Not sure if we're all using words the same way, so just in case...
|
* Repair the project structure. #9 (comment) * Remove 'public' from method in interface. This is a mistake, I do not know why this compiles on my machine but suspect that the compiler treats it as default method, but that is just a guess based on the error message that @Weegee received. https://discordapp.com/channels/634104110131445811/635510829499940912/694958697151070258 Co-Authored-By: weegee <[email protected]> * Update Infrastructure.csproj Co-authored-by: weegee <[email protected]>
This closes #3 and #12
Uses Co-Design for login/register.
There is no Core Api existing so that part should be done via another PR and a PR in the core rep.