Only query single route if segmentRange specified

[vishalkrishnads]

No description provided.

[github-actions]

Welcome to connect! Make sure to:

• read the contributing guidelines
• mark your PR as a draft until it's ready to review
• post the preview on Discord; feedback from users will speedup the PR review

deployed preview: https://522.connect-d5y.pages.dev

[sshane]

Loading all routes isn't an appropriate solution (speed), we should go and check how this used to work and replicate that. Was it an API query using the time ranges? Perhaps we can just query w/ the route name

[adeebshihadeh]

Loading all routes isn't an appropriate solution (speed), we should go and check how this used to work and replicate that. Was it an API query using the time ranges? Perhaps we can just query w/ the route name

We used to have the time range in the URL. We'll have to update the endpoint to also take a route name I guess.

[vishalkrishnads]

Yeah that makes the most sense.

[sshane]

Does this have everything we need? https://github.com/commaai/comma-api/blob/d23b152ea64bfcd0de0937d2d525d556870820b6/src/drives.js#L17

[vishalkrishnads]

Sorry, this doesn't. We need segment_start_times, segment_end_times & segment_numbers in the response to make this work. I think this should wait until #536 is closed.

[vishalkrishnads]

This issue has been fixed. for some reason, none of the CF pages related to my PR's are updating on subsequent commits. So, the URL related to this PR is outdated. However, the issue has been solved and the drives are loading.

[sshane]

This still doesn't work properly... It never recovers from this state:

Have a PR to properly fix this: #544

[vishalkrishnads]

i can't see the issue. seems fine for me

drive.loading.mp4

[sshane]

Very strange, I can reproduce it locally with pnpm start but not the deployed preview. Maybe something different in how it's run in production.

I changed it to only query the specific route on loading a route from URL, makes a bit more sense

[vishalkrishnads]

seems like it works now 😅

are you going to merge this or do you want me to clean up anything more?