Fix rgb camera for mac #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only 8-bit colors for mac - use glsl 330 for mac
|
@maxime-desroches Should this be merged into main and then to minimal, or straight into minimal? |
|
@maxime-desroches can you check this out? Looks like it's holding up macOS metadrive support |
|
Thanks for the PR. Once this is cleanup, I will merge this into main and create the new minimal wheel (and re-open your openpilot PR) |
| @@ -39,15 +40,17 @@ def _setup_effect(self): | |||
| self.manager = FilterManager(self.buffer, self.cam) | |||
| fbprops = p3d.FrameBufferProperties() | |||
| fbprops.float_color = True | |||
| fbprops.set_rgba_bits(16, 16, 16, 16) | |||
| # fbprops.set_rgba_bits(16, 16, 16, 16) | |||
| @@ -265,7 +265,7 @@ def _setup_tonemapping(self): | |||
|
|
|||
| fbprops = p3d.FrameBufferProperties() | |||
| fbprops.float_color = True | |||
| fbprops.set_rgba_bits(16, 16, 16, 16) | |||
| # fbprops.set_rgba_bits(16, 16, 16, 16) | |||
metadrive/engine/core/engine_core.py
Outdated
Comment on lines
107
to
108
| loadPrcFileData("", "color-bits 8 8 8") | ||
| loadPrcFileData("", "alpha-bits 8") |
There was a problem hiding this comment.
16 bits RGBA works fine on my mac. What are you testing this on?
|
Thanks for the review. Yes, manually setting 8-bit RGBA for Mac is indeed not needed anymore with the PBR pipeline working again, I missed that. |
maxime-desroches
added a commit
that referenced
this pull request
Dec 19, 2024
* fix rgb camera for mac - only 8-bit colors for mac - use glsl 330 for mac * macos 4x antialiasing * no more need to enforce 8-bit colors on mac * more samples * what is this, 1990? --------- Co-authored-by: Maxime Desroches <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes do you make in this PR?
Make the
RGBCamerawork on MacOS:python -m metadrive.examples.drive_in_single_agent_env --observation rgb_cameraChanges for MacOS:
Request only 8-bit colorsRequired for completing: commaai/openpilot#33207