Fixes engage % #76
Open
Fixes engage % #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should probably just come from the API, so all the logic is in one place. I'll have to look into that and come back to this. |
deployed preview: https://76.connect-d5y.pages.devWelcome to new-connect! Make sure to:
Mobile
Desktop
|
|
Looks to be better but like @adeebshihadeh said it would be best to get this directly from the API rather than calculating it on the client side. |
yeah agreed, was cool to solve nonetheless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75.
Ensures that the
engagedandoverridingstates are mutually exclusive. The old logic would attribute both these states toengaged, leading to inflated stats.