-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyundai: Allow controls with Sport and Manumatic Gears #34113
Conversation
0ae9a19
to
6b7b72e
Compare
After running against all 9000+ segments, only 2 results with the Sport gear on
|
Tests are failing due to
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Can we please reopen this? |
…phev-gear # Conflicts: # opendbc_repo
…phev-gear # Conflicts: # opendbc_repo
EV, HEV, PHEV
can you delete the notebook? |
Done! |
Description
When the vehicle is in manual or alternative drive modes (e.g., Sport), openpilot currently fails to recognize the signals and returns with an “Gear not D” event, exiting the controls.
Added Jupyter notebook for validating Sport gear for CAN hybrid and electric vehicles.
Solution
This pull request implements support for parsing various forward gear signals and adds additional undefined forward gear signals to the DBC.
Validation
Requires
EV, HEV, PHEV
opendbc#1530Reopen of
EV, HEV, PHEV
#30648Elect_Gear_Shifter
Sport Gear value opendbc#981