Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[date] Add tz recipe as a dependency #22294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[date] Add tz recipe as a dependency #22294

wants to merge 2 commits into from

Commits on Jan 13, 2024

  1. [date] Add tz recipe as a dependency 

    * Add tz recipe as a dependency to provide a way of easily
  consuming/maintaining and upgrading the timezone database
* Apply patch from HowardHinnant/date#807 to add the ability to specify
  the tz database by environment variable
* Deprecate `use_system_tz_db` in favour of `with_tzdb` option to handle
  all mutually exclusive options
* Add `with_db_format` option to provide flexibility in how the tz
  package is consumed.

This implementation superesedes conan-io#16285 and conan-io#21719. In the case of conan-io#21719,
it turned out that HowardHinnant/date#611 was not mature enough to
provide the ability for the date library to read zic-compiled binary
variants of the tzdb on Windows. To take an iterative approach, this PR
aims to extract the elements that worked from conan-io#21719, which was the use
of an environment variable to inject the conan packaged tz database.

Use of a binary database has been marked as an invalid configuration on
Windows. This functionality can be added at a later date.

This pull request is blocked on conan-io#21671, which packages the source
database in the tz recipe and makes this the default configuration since
this is the only database that can be parsed consistently on all major
platforms.

Closes conan-io#16204
    @samuel-emrys
    samuel-emrys committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    541308d View commit details
    Browse the repository at this point in the history

  2. [date] Resolve ambiguities in symbol resolution in test_package

    @samuel-emrys
    samuel-emrys committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    1beb37a View commit details
    Browse the repository at this point in the history