Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date] Add tz recipe as a dependency #22294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samuel-emrys
Copy link
Contributor

@samuel-emrys samuel-emrys commented Jan 13, 2024

This implementation supersedes #16285 and #21719. In the case of #21719, it turned out that HowardHinnant/date#611 was not mature enough to provide the ability for the date library to read zic-compiled binary variants of the tzdb on Windows. To take an iterative approach, this PR aims to extract the elements that worked from #21719, which was the use of an environment variable to inject the conan packaged tz database.

Use of a binary database has been marked as an invalid configuration on Windows. This functionality can be added at a later date.

This pull request is blocked on #21671, which packages the source database in the tz recipe and makes this the default configuration since this is the only database that can be parsed consistently on all major platforms.

Blocked by #21671
Closes #16204

Specify library name and version: date/3.0.1


* Add tz recipe as a dependency to provide a way of easily
  consuming/maintaining and upgrading the timezone database
* Apply patch from HowardHinnant/date#807 to add the ability to specify
  the tz database by environment variable
* Deprecate `use_system_tz_db` in favour of `with_tzdb` option to handle
  all mutually exclusive options
* Add `with_db_format` option to provide flexibility in how the tz
  package is consumed.

This implementation superesedes conan-io#16285 and conan-io#21719. In the case of conan-io#21719,
it turned out that HowardHinnant/date#611 was not mature enough to
provide the ability for the date library to read zic-compiled binary
variants of the tzdb on Windows. To take an iterative approach, this PR
aims to extract the elements that worked from conan-io#21719, which was the use
of an environment variable to inject the conan packaged tz database.

Use of a binary database has been marked as an invalid configuration on
Windows. This functionality can be added at a later date.

This pull request is blocked on conan-io#21671, which packages the source
database in the tz recipe and makes this the default configuration since
this is the only database that can be parsed consistently on all major
platforms.

Closes conan-io#16204
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (1beb37a3a29b600b8ab809897f183b4eea152f93):

  • date/3.0.0:
    All packages built successfully! (All logs)

  • date/2.4.1:
    All packages built successfully! (All logs)

  • date/3.0.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 2 (1beb37a3a29b600b8ab809897f183b4eea152f93):

  • date/2.4.1:
    Error running command conan graph info --requires date/2.4.1@#7f79c754ee45d3d222d8d88af3998d9c -f json -pr:h /home/conan/w/prod-v2/bsr/72875/caeaf/profile_linux_11_libstdcpp11_17_gcc_release_64.-shared-False_date-header_only-False.txt -pr:b /home/conan/w/prod-v2/bsr/72875/caeaf/profile_linux_11_libstdcpp11_17_gcc_release_64..txt:

    ======== Computing dependency graph ========
    tz/2023c: Not found in local cache, looking in remotes...
    tz/2023c: Checking remote: conan-center
    tz/2023c: Downloaded recipe revision 0ad5cf387a5e3d7ed63eb5492dbc57ba
    ERROR: option 'with_binary_db' doesn't exist
    Possible options are []
    
  • date/3.0.1:
    Didn't run or was cancelled before finishing

  • date/3.0.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] date/3.0.1: Should package the tzdata database with the package
2 participants