Add post-install test to make sure installation works on all supported platforms #229
+264
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
bot
force-pushed
the
dev_post_install_tests
branch
from
b05d95e to
8c13757
Compare
This comment has been minimized.
This comment has been minimized.
emasab
requested changes
Jan 20, 2025
.semaphore/project.yml
Outdated
| @@ -42,3 +42,13 @@ spec: | |||
| - pull_request | |||
| - forked_pull_request | |||
| - tag | |||
| tasks: | |||
There was a problem hiding this comment.
I think you have to add this task in service.yml otherwise this will be overwritten as stated in the header
.semaphore/post_install.yml
Outdated
Comment on lines
1
to
6
| # This file is managed by ServiceBot plugin - Semaphore. The content in this file is created using a common | ||
| # template and configurations in service.yml. | ||
| # Any modifications made to version, name, agent, and global_job_config will be overwritten by the generated | ||
| # content in nightly runs. Code changes made to the remaining sections will not be affected. | ||
| # For more information, please refer to the page: | ||
| # https://confluentinc.atlassian.net/wiki/spaces/Foundations/pages/2871296194/Add+SemaphoreCI |
There was a problem hiding this comment.
This file won't be managed by ServiceBot plugin, only project.yml should be, you can remove this comment.
Suggested change
| # This file is managed by ServiceBot plugin - Semaphore. The content in this file is created using a common | |
| # template and configurations in service.yml. | |
| # Any modifications made to version, name, agent, and global_job_config will be overwritten by the generated | |
| # content in nightly runs. Code changes made to the remaining sections will not be affected. | |
| # For more information, please refer to the page: | |
| # https://confluentinc.atlassian.net/wiki/spaces/Foundations/pages/2871296194/Add+SemaphoreCI |
airlock-confluentinc
bot
force-pushed
the
dev_post_install_tests
branch
from
045306a to
f99db41
Compare
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-javascript |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs:
Once we do a 1.1.0-rcX release, I'll run the post install test one last time to verify it.
Accompanying PR for #228 to prevent issues like #221.