Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: batch write race on commit #983

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: batch write race on commit #983

merged 1 commit into from
Sep 23, 2024

Conversation

corverroos
Copy link
Contributor

Wait for previous batch before writing batch on importer.Commit

@corverroos corverroos requested a review from a team as a code owner August 19, 2024 10:25
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 19, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@corverroos corverroos mentioned this pull request Aug 19, 2024
Closed
@corverroos
Copy link
Contributor Author

For more context, see this issue on omni that resulted in this PR.

corverroos
corverroos commented Aug 19, 2024
View reviewed changes
import.go
// Wait for previous batch.
var err error
if i.inflightCommit != nil {
err = <-i.inflightCommit
Copy link
Contributor Author

@corverroos corverroos Aug 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe using a sync.Mutex around batch.Write(Sync) and batch.Commit would be easier to reason about?

cool-develope
cool-develope approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@cool-develope cool-develope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

kocubinski
kocubinski approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@kocubinski kocubinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, lgtm

@cool-develope
Copy link
Collaborator

@Mergifyio backport master

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 27, 2024 •
edited
Loading

backport master

🛑 Command backport master cancelled because of a new backport command with different arguments

@corverroos
Copy link
Contributor Author

corverroos commented Sep 19, 2024 •
edited
Loading

Hi all, is there anything more I need to do from my side?

@tac0turtle tac0turtle merged commit fe80f0a into cosmos:release/v1.1.x Sep 23, 2024
5 checks passed
@tac0turtle
Copy link
Member

@Mergifyio backport master

mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@corverroos @mergify
fix: batch write race on commit (#983)
05fd70e 
(cherry picked from commit fe80f0a)
@mergify mergify bot mentioned this pull request Sep 23, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 23, 2024

backport master

✅ Backports have been created

tac0turtle pushed a commit that referenced this pull request Sep 23, 2024
@mergify @corverroos
fix: batch write race on commit (backport #983) (#992)
34895bf 
Co-authored-by: corver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cool-develope cool-develope cool-develope approved these changes

@kocubinski kocubinski kocubinski approved these changes

Assignees

@kocubinski kocubinski

@cool-develope cool-develope

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corverroos @cool-develope @tac0turtle @kocubinski