Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch write race on commit #983

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: batch write race on commit #983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion import.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,17 @@ func (i *Importer) Commit() error {
len(i.stack))
}

err := i.batch.WriteSync()
// Wait for previous batch.
var err error
if i.inflightCommit != nil {
err = <-i.inflightCommit
Copy link
Contributor Author

@corverroos corverroos Aug 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe using a sync.Mutex around batch.Write(Sync) and batch.Commit would be easier to reason about?

i.inflightCommit = nil
}
if err != nil {
return err
}

err = i.batch.WriteSync()
if err != nil {
return err
}
Expand Down
Loading