Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instalation instruction for Ubuntu cri-o.io #42

Closed
wants to merge 3 commits into from

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Apr 19, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Apr 19, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Slach
To complete the pull request process, please assign haircommander
You can assign the PR to them by writing /assign @haircommander in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Slach
Copy link
Contributor Author

Slach commented Apr 19, 2020

/assign @haircommander

@Slach
Copy link
Contributor Author

Slach commented Apr 19, 2020

how I can add DCO signoff?

@TomSweeneyRedHat
Copy link
Contributor

@Slach you need to do git commit --amend -s and then repush.
The changes LGTM

@openshift-ci-robot
Copy link

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 170d880 update instalation instruction for Ubuntu cri-o.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Slach Slach closed this Apr 20, 2020
@Slach Slach deleted the patch-1 branch April 20, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: no Indicates the PR's author has not DCO signed all their commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants