amsl_origin and utm_origin now correctly use altitude from RTK instead of GNSS #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge only when we verify that this works in real world. So far we have tested it in sim only.
amsl_origin
,utm_origin
) published by transform_manager were based on the topichw_api/altitude
, which was based on the GNSS altitude reported by mavros/pixhawk.fcu
->rtk_antenna
to transform the measurements received by the antenna into the fcu frame, which is typically offset vertically on the drones.fcu
->rtk_antenna
tf was previously published fromsensors.launch
but I deleted the tf from the launch file because it is drone-specific and thus is the responsibility of the user to provide them in the tmux session. If the tf is not provided, transform manager will crash and inform the user to provide the tf.fcu
->amsl_origin
- contains only the amsl altitude (no xy position or orientation),fcu
->utm_origin
- contains the amsl altitude, the xy position in the utm frame (latlon converted to meters), and the orientation.hw_api/gnss
(pixhawk) andhw_api/rtk
(emlid) will differ by tens of meters (depending on the location).