Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix router issues #1794

Merged
merged 5 commits into from
May 30, 2024
Merged

Fix router issues #1794

merged 5 commits into from
May 30, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented May 13, 2024

  • Set page title per-route rather than per-view

  • Improve router error handling & tidy

  • Address this warning that has been around for ages:

    [Vue Router warn]: <router-view> can no longer be used directly inside <transition>
    
  • Removes @unhead/vue dependency as it is a bit overkill for just setting the page title, which can be done simply using document.title = title

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included
  • Changelog not needed as not user-facing

@MetRonnie MetRonnie added this to the 2.6.0 milestone May 13, 2024
@MetRonnie MetRonnie self-assigned this May 13, 2024
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not too fussed about loosing the fade transition)

@MetRonnie MetRonnie requested a review from wxtim May 29, 2024 09:22
@wxtim wxtim merged commit 949e586 into cylc:master May 30, 2024
8 checks passed
@MetRonnie MetRonnie modified the milestones: 2.6.0, 2.5.0 May 30, 2024
@MetRonnie MetRonnie deleted the router branch May 30, 2024 14:14
@MetRonnie MetRonnie added bug Something isn't working dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants