-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poetry dynamic versioning and update release process #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this tooling brought to cytotable too! LGTM
Thank you @kenibrewer ! Definitely inspired by your great work in Pycytominer! 🙂 |
@kenibrewer , thanks again for your review here! Would you like to be a CytoTable maintainer? I feel that the project could benefit from your insights. If so, let me know and I'll send along an invite. |
@d33bs Sure! I already watch this repo so I can stay aware of the upstream changes that might impact |
Thanks a bunch @kenibrewer - added! |
Description
This PR adds dynamic versioning changes intended to eventually assist with #19 by adding CytoTable version metadata into Parquet output. The goal is to enable dynamic version capture in both development (git source-based) and published releases (PyPI, etc), meaning data created by CytoTable from either path would be accurately versioned (enhancing data provenance / lineage understanding for audiences). While
dunamai
and__version__
aren't necessarily required yet, I intend to use them with further changes towards #19 and thought early discussion / review / visibility might assist.As part of this I had to update the release process and tried to practice DRY better with GitHub Actions during the process. I also updated the pre-commit check versions as a general act of good source-keeping.
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.