Retry aggregate_assets_summary_task on version metadata race condition #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
force-pushed
the
retry-assets-summary
branch
from
326ab72
to
9dc252f
Compare
danlamanna
requested changes
Jan 2, 2024
jjnesbitt
force-pushed
the
retry-assets-summary
branch
from
9dc252f
to
9bc1979
Compare
jjnesbitt
added
patch
| @@ -95,6 +96,7 @@ def version_aggregate_assets_summary(version: Version) -> None: | |||
| ) | |||
| if updated_count == 0: | |||
| logger.info('Skipped updating assetsSummary for version %s', version.id) | |||
| raise VersionMetadataConcurrentlyModified | |||
There was a problem hiding this comment.
Will this trigger a Sentry error? I imagine we wouldn't want that to happen in this case.
There was a problem hiding this comment.
I don't think it will. I believe what happens is the following:
- This exception is raised
- Since the task is decorated with
autoretry_for, it catches that exception and raises a celeryRetryexception (documented here) - Sentry (specific the celery integration) sees the
Retryexception is raised, but ignores it, as it's recognized as part of celery's control flow. Here is the code that controls that.
So we should be good, but I'll do a little more testing to make sure things behave as we expect before merging.
mvandenburgh
approved these changes
Jan 16, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1734
Related to #1800. Both this PR and #1800 address #1734, although this change should cover all sources of a concurrent metadata change, instead of just the
validate_version_metadatatask.