Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigated include-what-you-use warnings #330

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Nov 13, 2023

include-what-you-use and clang-include-cleaner disagree about this. Since we have the latter enabled in this repo appease it for now by re-adding the include and suppress the IWYU warning.

@firewave firewave marked this pull request as draft November 14, 2023 14:13
@firewave firewave changed the title cleaned up includes based on include-what-you-use mitigated include-what-you-use warning Apr 23, 2024
@firewave firewave marked this pull request as ready for review April 23, 2024 09:34
@firewave firewave marked this pull request as draft April 23, 2024 15:48
@firewave firewave changed the title mitigated include-what-you-use warning mitigated include-what-you-use warnings Apr 23, 2024
@firewave
Copy link
Collaborator Author

I accidentally modified the file downstream in danmar/cppcheck@f465dc5 instead of applying them upstream.

@firewave firewave marked this pull request as ready for review April 23, 2024 15:51
@danmar danmar merged commit 3678cd1 into danmar:master Apr 24, 2024
14 checks passed
@firewave firewave deleted the iwyu branch April 24, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants