-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add image pull policy #1462
add image pull policy #1462
Conversation
Signed-off-by: Filinto Duran <[email protected]>
a170e7c
to
448ecae
Compare
Signed-off-by: Filinto Duran <[email protected]>
@artursouza @antontroshin please check |
Signed-off-by: Filinto Duran <[email protected]>
9783d1b
@antontroshin @elena-kolevska could you re-approved? I added the feedback from @antontroshin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a little unit test pls?
https://github.com/dapr/cli/blob/master/pkg/runfileconfig/run_file_config_parser_test.go
Signed-off-by: Filinto Duran <[email protected]>
@elena-kolevska please take another look. thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter is failing, but other than that, lgtm
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super helpful for local development @filintod , thank you very much!
Upgrade tests are failing, is this related? |
@yaron2 I've re-run the tests, and they all passed, except for regular Podman failure on macOS, which is on my plate for the near future. |
@holopin-bot @filintod Thanks Filinto! |
Congratulations @filintod, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm5qxul0p17180clbbpi58lsp This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
Currently one cannot use the kubernetes run when using an image loaded to a kind cluster as the image pull policy is hard coded to Always. This changes it to make it configurable.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1463
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: