Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP csharp jobs quickstart #1136

Open
wants to merge 3 commits into
base: release-1.15
Choose a base branch
from
Open

HTTP csharp jobs quickstart #1136

wants to merge 3 commits into from
+428 −3

Conversation

alicejgibbons
Copy link

Description

HTTP csharp jobs quickstart, plus a few edits to the Go HTTP quickstart readme for verbiage updates.

Issue reference

Issue this PR will close: #1113

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@alicejgibbons alicejgibbons requested review from a team as code owners January 20, 2025 22:07
rochabr
rochabr approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@rochabr rochabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alicejgibbons
Tests updates
b8ef1c0 
Signed-off-by: Alice Gibbons <[email protected]>
@alicejgibbons
HTTP csharp jobs quickstart
dcf1f9f 
Signed-off-by: Alice Gibbons <[email protected]>
@alicejgibbons
Copy link
Author

Need to rebase once cherry picked commit is merged

@paulyuk
Copy link
Contributor

paulyuk commented Jan 22, 2025 •
edited
Loading

Rerunning checks for python and C# now that #1141 and dapr/cli#1478 are merged

@paulyuk
Copy link
Contributor

paulyuk commented Jan 22, 2025

Just pushed hotfix to get CLI rc.2 into our tests.

paulyuk
paulyuk approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You're carrying extra payload of crypto changes. Let's see if tests go and no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulyuk paulyuk paulyuk approved these changes

@rochabr rochabr rochabr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alicejgibbons @paulyuk @rochabr @mikeee