Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add configurable export IP #201

Merged
merged 7 commits into from
Apr 17, 2024
Merged

fix: add configurable export IP #201

merged 7 commits into from
Apr 17, 2024

Conversation

mdutka-dell
Copy link
Contributor

@mdutka-dell mdutka-dell commented Apr 3, 2024 •
edited
Loading

Description

Mechanism for selecting custom networks for array traffic in csi-unity.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1222

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Configurable export IP is a feature that allows to set allowed networks. To test changes it is required to run install cases with new parameter and without it.

  • Unit tests - add new test cases
  • Manually install helm chart with and without allowedNetworks parameter
  • run cert-csi test suite

@mdutka-dell mdutka-dell marked this pull request as draft April 3, 2024 08:28
@mdutka-dell mdutka-dell force-pushed the configurable_export_ip branch from 21759b5 to 4e438b6 Compare April 3, 2024 10:35
@mdutka-dell mdutka-dell changed the base branch from release-v2.10.1 to main April 3, 2024 12:09
@mdutka-dell mdutka-dell force-pushed the configurable_export_ip branch from 4e438b6 to 6a7b306 Compare April 4, 2024 09:03
@mdutka-dell mdutka-dell marked this pull request as ready for review April 4, 2024 09:55
Leonard-Dell
Leonard-Dell previously approved these changes Apr 9, 2024
View reviewed changes
Copy link

@Leonard-Dell Leonard-Dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

adamginna-dell
adamginna-dell previously approved these changes Apr 9, 2024
View reviewed changes
gallacher
gallacher previously requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any unit testing added here. Please also ensure the new e2e test scenarios are added if needed. Please also ensure that e2e tests are executed and results are attached to the PR.

@mdutka-dell mdutka-dell dismissed stale reviews from adamginna-dell and Leonard-Dell via 19b7b56 April 9, 2024 15:21
@mdutka-dell mdutka-dell requested a review from gallacher April 11, 2024 09:56
@mdutka-dell mdutka-dell force-pushed the configurable_export_ip branch from a3da201 to d93a4dc Compare April 15, 2024 10:12
@cbartoszDell cbartoszDell dismissed gallacher’s stale review April 17, 2024 10:55

Unit tests have been writen

@cbartoszDell cbartoszDell merged commit 33a4cfb into main Apr 17, 2024
4 checks passed
@shefali-malhotra shefali-malhotra deleted the configurable_export_ip branch June 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panigs7 panigs7 panigs7 approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@cbartoszDell cbartoszDell Awaiting requested review from cbartoszDell

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@gallacher gallacher Awaiting requested review from gallacher

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mdutka-dell @gallacher @rajendraindukuri @panigs7 @adamginna-dell @Leonard-Dell @cbartoszDell @bogdanNovikovDell