Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Helm Installation checking Snapshot CRD Only When Snapshot Enabled is True #253

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Fix for Helm Installation checking Snapshot CRD Only When Snapshot Enabled is True #253

merged 3 commits into from
Jan 1, 2025

Conversation

WilsonRadadia20
Copy link
Contributor

Description

Updating the code for the Helm Installation that will check Snapshot CRD Only When Snapshot Enabled is True

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1654

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Install the driver:
    image (4)

@karthikk92 karthikk92 merged commit fd5fc8f into main Jan 1, 2025
5 of 6 checks passed
@karthikk92 karthikk92 deleted the bug-31403-snapshot-check branch January 1, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgandharva mgandharva mgandharva approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WilsonRadadia20 @karthikk92 @mgandharva