Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Helm Installation checking Snapshot CRD Only When Snapshot Enabled is True #253

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Fix for Helm Installation checking Snapshot CRD Only When Snapshot Enabled is True #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df69703
Update for installation check of the snapshot
WilsonRadadia20 Dec 31, 2024
36cc2e7
Update the k8s version
WilsonRadadia20 Dec 31, 2024
5cf26d3
Remove the unnecessary echo
WilsonRadadia20 Jan 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions dell-csi-helm-installer/verify-csi-unity.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,18 @@ function verify-csi-unity() {
verify_namespace "${NS}"
verify_required_secrets "${RELEASE}-creds"
verify_optional_secrets "${RELEASE}-certs"
verify_alpha_snap_resources
snapshot_value=$(is_snapshot_enabled)
if [ "$snapshot_value" == "true" ]; then
verify_alpha_snap_resources
fi
verify_unity_protocol_installation
verify_snap_requirements
if [ "$snapshot_value" == "true" ]; then
verify_snap_requirements
fi
verify_helm_3
verify_helm_values_version "${DRIVER_VERSION}"
}


function verify_unity_protocol_installation() {
if [ ${NODE_VERIFY} -eq 0 ]; then
return
Expand Down
4 changes: 4 additions & 0 deletions dell-csi-helm-installer/verify.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ function source-verify-driver() {
fi
}

function is_snapshot_enabled() {
snapshot_enabled=$(sed -n '/snapshot:/,/resizer:/p' "$VALUES" | grep -v '^\s*#' | grep "enabled:" | awk '{print $2}')
}


#
# verify-driver will call the proper method to verify a specific driver
Expand Down
Loading