-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update NDK to r27 #3229
base: main
Are you sure you want to change the base?
build: update NDK to r27 #3229
Conversation
Let's not merge for now, maybe we even can restore Android 4 support. There is no urgent need to upgrade and need to check F-Droid build again if we do. |
Built and installed this, seems to work. |
I just lowered the support to 19 (android 4.4) |
@@ -7,57 +7,6 @@ | |||
#include "deltachat-core-rust/deltachat-ffi/deltachat.h" | |||
|
|||
|
|||
#if __ANDROID_API__ == 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One advantage of dropping these Android 16 hacks is that we may be able to get rid of C code completely: https://openjdk.org/jeps/389
To test the changes in this pull request, install this apk: |
37448cd
to
851d9b9
Compare
To test the changes in this pull request, install this apk: |
Since we use minSdk 21 now, can also merge this. And then tag a release and reenable F-Droid builds with r27 NDK. |
To test the changes in this pull request, install this apk: |
a8dc9af
to
ecd45b9
Compare
To test the changes in this pull request, install this apk: |
ecd45b9
to
9394c83
Compare
To test the changes in this pull request, install this apk: |
9394c83
to
1bf4816
Compare
To test the changes in this pull request, install this apk: |
1bf4816
to
7d2b466
Compare
To test the changes in this pull request, install this apk: |
7d2b466
to
27a9a73
Compare
To test the changes in this pull request, install this apk: |
27a9a73
to
2662ca2
Compare
To test the changes in this pull request, install this apk: |
2662ca2
to
d23859a
Compare
To test the changes in this pull request, install this apk: |
If we are dropping Android 4 support anyway, can as well upgrade to the current LTS NDK which requires API level 21 (Android 5.0).
d23859a
to
e40b4fb
Compare
To test the changes in this pull request, install this apk: |
If we are dropping Android 4 support anyway,
can as well upgrade to the current LTS NDK
which requires API level 21 (Android 5.0).